[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=167547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167547
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/18 23:40
Start Date: 19/Nov/18 23:40
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6925:
[BEAM-5315] Partially port IO: avro schema parsing and codecs
URL: https://github.com/apache/beam/pull/6925#discussion_r234822883
##########
File path: sdks/python/apache_beam/io/avroio.py
##########
@@ -360,8 +360,10 @@ def num_records(self):
def records(self):
decoder = avroio.BinaryDecoder(
io.BytesIO(self._decompressed_block_bytes))
- reader = avroio.DatumReader(
- writers_schema=self._schema, readers_schema=self._schema)
+ # Kwargs writers_schema and readers_schema were renamed to
+ # writer_schema and reader_schema in py3.
+ # Therefore, the kwargs were left out to be both py2 and py3 compatible.
Review comment:
This comment is relevant for PR review, but I think it's not necessary for
readers of the code. I suggest we remove it. If we want to keep the names of
positional arguments for readability, we can do:
```
writer_schema=self._schema
reader_schema=self._schema
reader = avroio.DatumReader(
writer_schema, reader_schema)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167547)
Time Spent: 6h 10m (was: 6h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
