[
https://issues.apache.org/jira/browse/BEAM-6094?focusedWorklogId=173147&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-173147
]
ASF GitHub Bot logged work on BEAM-6094:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Dec/18 02:05
Start Date: 08/Dec/18 02:05
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #7078:
[BEAM-6094] Implement external environment for portable BeamPython.
URL: https://github.com/apache/beam/pull/7078#discussion_r239988252
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -967,3 +967,23 @@ service BeamFnLogging {
stream LogControl
) {}
}
+
+
+message StartWorkerRequest {
+ string worker_id = 1;
+ org.apache.beam.model.pipeline.v1.ApiServiceDescriptor control_endpoint = 2;
+ org.apache.beam.model.pipeline.v1.ApiServiceDescriptor logging_endpoint = 3;
+ org.apache.beam.model.pipeline.v1.ApiServiceDescriptor artifact_endpoint = 4;
+ org.apache.beam.model.pipeline.v1.ApiServiceDescriptor provision_endpoint =
5;
+ map<string, string> params = 10;
+}
+
+message StartWorkerResponse {
+ string error = 1;
+}
+
+service BeamFnExternalWorker {
Review comment:
The intent here is to tell that the worker that it runner is available on
certain ports.
How about service name `BeamFnExternalWorker` -> `BeamFnExternalWorkerPool`
And rpc method name `StartWorker` - > `NotifyRunnerAvailable`
Also, in this case we should end the loop with `NotifyRunnerComplete`
This will help the WorkerPool to recycle worker efficiently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 173147)
> Implement External environment for Portable Beam
> ------------------------------------------------
>
> Key: BEAM-6094
> URL: https://issues.apache.org/jira/browse/BEAM-6094
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
