[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=620074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-620074
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jul/21 16:39
Start Date: 07/Jul/21 16:39
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r665537989
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -362,6 +368,19 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
}
private @MonotonicNonNull Map<String, TransformProvider>
registeredTransforms;
+ private final PipelineOptions pipelineOptions;
+
+ public ExpansionService() {
+ this(new String[] {});
+ }
+
+ public ExpansionService(String[] args) {
+ this(PipelineOptionsFactory.fromArgs(args).create());
+ }
+
+ public ExpansionService(PipelineOptions opts) {
Review comment:
We can do that, but the question is which case exactly do we want to
solve. My initial feeling was that we want to throw exception when user sets
option that is not supported (that is, might not be respected by the
ExpansionService). Extracting 'supported' features will not help this -
unsupported options will still be silently ignored by the service, pretty much
the same way as we do not extract it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 620074)
Time Spent: 6h (was: 5h 50m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 6h
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
