[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=621195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621195
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/21 21:51
Start Date: 09/Jul/21 21:51
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r667227991
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -462,6 +488,9 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
throw new RuntimeException(exn);
}
}));
+
+
SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);
Review comment:
So IMO the default path should be SDF.
All portable runners are expected to support SDF.
Multi-language only works for portable runners.
Flink supporting non-SDF sources is a special case. But if we need to
support that it should be behind the experiment "use_deprecated_read". Default
path (SDF) should not require an experiment .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621195)
Time Spent: 6.5h (was: 6h 20m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
