[
https://issues.apache.org/jira/browse/BEAM-12538?focusedWorklogId=621244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621244
]
ASF GitHub Bot logged work on BEAM-12538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/21 08:11
Start Date: 10/Jul/21 08:11
Worklog Time Spent: 10m
Work Description: je-ik commented on a change in pull request #15082:
URL: https://github.com/apache/beam/pull/15082#discussion_r667308702
##########
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##########
@@ -486,6 +515,19 @@ default InputT createInput(Pipeline p, Map<String,
PCollection<?>> inputs) {
.build();
}
+ protected Pipeline createPipeline() {
+ PipelineOptions effectiveOpts = PipelineOptionsFactory.create();
Review comment:
I created new PipelineOptions per expansion and copy the important
options from the command-line. On the other hand I think, that from user
perspective this has very low difference, because the main issue here is that
the user (with good intentions) specifies an option that is not supported by
the service (e.g. most obviously the `runner`). The command line will accept
it, but it will be simply silently ignored. I think that is the case we need to
address by the validation scope annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621244)
Time Spent: 6h 50m (was: 6h 40m)
> Allow ExpansionService to accept PipelineOptions
> ------------------------------------------------
>
> Key: BEAM-12538
> URL: https://issues.apache.org/jira/browse/BEAM-12538
> Project: Beam
> Issue Type: Improvement
> Components: cross-language
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> ExpansionService does not accept command-line arguments (other than port
> number). It is needed to allow it to accept at least
> {{defaultEnvironmentType}} and {{defaultEnvironmentConfig}} from
> {{PortablePipelineOptions}} to be able to specify environment of the expanded
> transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
