[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=649371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649371
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/21 18:23
Start Date: 10/Sep/21 18:23
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-917116597
@benWize I tried running Google compliance tests on this PR again. Most
tests pass, but this test crashes:
https://github.com/google/zetasql/blob/dd883180de6387ad80bcf7534b5aae8191e66621/zetasql/compliance/testdata/aggregation_queries.test#L1591
```
java.lang.RuntimeException: Could not construct an accumulator Coder for
Inner{inputSchema=Fields:
Field{name=$col1, description=, type=INT64 NOT NULL, options={{}}}
Encoding positions:
{$col1=0}
Options:{{}}UUID: 0e4f58b4-f7ac-4531-a10d-df770ec2f974, outputSchema=Fields:
Field{name=$col1, description=, type=INT64, options={{}}}
Encoding positions:
{$col1=0}
Options:{{}}UUID: null,
composedCombineFn=org.apache.beam.sdk.transforms.CombineFns$ComposedCombineFn@46d36c10,
fieldAggregations=[org.apache.beam.sdk.schemas.transforms.SchemaAggregateFn$Inner$FieldAggregation@2e410f14]}.
Accumulator Coder for a Combine may be null, but may not throw an exception
at
org.apache.beam.runners.direct.MultiStepCombine$1.isApplicable(MultiStepCombine.java:114)
at
org.apache.beam.runners.direct.MultiStepCombine$1.matches(MultiStepCombine.java:83)
at
org.apache.beam.sdk.Pipeline$2.enterCompositeTransform(Pipeline.java:278)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.visit(TransformHierarchy.java:581)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.visit(TransformHierarchy.java:585)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.visit(TransformHierarchy.java:585)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.visit(TransformHierarchy.java:585)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.visit(TransformHierarchy.java:585)
at
org.apache.beam.sdk.runners.TransformHierarchy$Node.access$500(TransformHierarchy.java:240)
at
org.apache.beam.sdk.runners.TransformHierarchy.visit(TransformHierarchy.java:214)
at org.apache.beam.sdk.Pipeline.traverseTopologically(Pipeline.java:469)
at org.apache.beam.sdk.Pipeline.replace(Pipeline.java:268)
at org.apache.beam.sdk.Pipeline.replaceAll(Pipeline.java:218)
at
org.apache.beam.runners.direct.DirectRunner.performRewrites(DirectRunner.java:246)
at
org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:175)
at org.apache.beam.runners.direct.DirectRunner.run(DirectRunner.java:67)
at org.apache.beam.sdk.Pipeline.run(Pipeline.java:323)
at org.apache.beam.sdk.Pipeline.run(Pipeline.java:309)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamEnumerableConverter.runCollector(BeamEnumerableConverter.java:217)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamEnumerableConverter.collectRows(BeamEnumerableConverter.java:236)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamEnumerableConverter.toRowList(BeamEnumerableConverter.java:163)
at
org.apache.beam.sdk.extensions.sql.impl.rel.BeamEnumerableConverter.toRowList(BeamEnumerableConverter.java:139)
at
cloud.dataflow.sql.ExecuteQueryServiceServer$SqlComplianceServiceImpl.executeQuery(ExecuteQueryServiceServer.java:309)
at
com.google.zetasql.testing.SqlComplianceServiceGrpc$MethodHandlers.invoke(SqlComplianceServiceGrpc.java:423)
at
com.google.zetasql.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:171)
at
com.google.zetasql.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:283)
at
com.google.zetasql.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:711)
at
com.google.zetasql.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
at
com.google.zetasql.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:830)
Caused by: org.apache.beam.sdk.coders.CannotProvideCoderException: Cannot
infer coder for type parameter AccumT
at
org.apache.beam.sdk.coders.CoderRegistry.getCoder(CoderRegistry.java:328)
at
org.apache.beam.sdk.transforms.CombineFnBase$AbstractGlobalCombineFn.getAccumulatorCoder(CombineFnBase.java:119)
at
org.apache.beam.sdk.transforms.Combine$CombineFn.getAccumulatorCoder(Combine.java:389)
at
org.apache.beam.sdk.extensions.sql.impl.transform.agg.AggregationCombineFnAdapter$WrappedCombinerBase.getAccumulatorCoder(AggregationCombineFnAdapter.java:72)
at
org.apache.beam.sdk.transforms.CombineFns$ComposedCombineFn.getAccumulatorCoder(CombineFns.java:430)
at
org.apache.beam.sdk.schemas.transforms.SchemaAggregateFn$Inner.getAccumulatorCoder(SchemaAggregateFn.java:335)
at
org.apache.beam.runners.direct.MultiStepCombine$1.isApplicable(MultiStepCombine.java:106)
... 31 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 649371)
Time Spent: 11h (was: 10h 50m)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 11h
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
