[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=649465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649465
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/21 20:47
Start Date: 10/Sep/21 20:47
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-917201142
@benWize Thanks, that fixed the error. The tests are no longer crashing, but
6 failures remain:
- aggregation_queries_test:aggregation_array_agg_1
- aggregation_queries_test:array_agg_empty_input
- aggregation_queries_test:aggregation_36
- aggregation_queries_test:aggregation_53
- aggregation_queries_test:aggregation_58
- aggregation_queries_test:aggregation_62
https://github.com/google/zetasql/blob/dd883180de6387ad80bcf7534b5aae8191e66621/zetasql/compliance/testdata/aggregation_queries.test
I took a quick look at the errors, and it seems they are all related to null
handling. (I'm guessing these are all test cases where the SQL query failed to
compile before, but now they're compiling and giving wrong answers.)
- Some functions are expected to return null when the input is empty.
- BIT_AND, BIT_OR, etc. are expected to ignore null input mixed with
non-null inputs. I think the current implementations of these functions in Beam
are incorrect. The compliance tests are the source of truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 649465)
Time Spent: 11h 50m (was: 11h 40m)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
