[ 
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=650260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650260
 ]

ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Sep/21 23:05
            Start Date: 13/Sep/21 23:05
    Worklog Time Spent: 10m 
      Work Description: benWize commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-918647393


   @ibzib I copied most of the tests to check the fixes, I was able to fix null 
handling for `BitOr` and `BitAnd`, but in the case of `BitXOr` and `Array_Agg` 
it shows an error because the `inferedType` by Calcite is BIGINT NOT NULL, so 
when trying to return `null` (Like in an empty input) fails by type mismatch 
(`ARRAY<INT64 NOT NULL> NOT NULL is not nullable`). 
https://github.com/apache/beam/blob/8adc4370e462ce9c1c0eb7472aea53be707d7cd5/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java#L259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 650260)
    Time Spent: 12h 10m  (was: 12h)

> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
>                 Key: BEAM-12100
>                 URL: https://issues.apache.org/jira/browse/BEAM-12100
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql-zetasql
>            Reporter: Kyle Weaver
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1 
> UNION ALL SELECT CAST(1 as int64))
> should return an error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to