[ 
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=650774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650774
 ]

ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Sep/21 20:25
            Start Date: 14/Sep/21 20:25
    Worklog Time Spent: 10m 
      Work Description: benWize commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-919487157


   Thanks, @ibzib I fixed null handling for BitXor with your suggestion, and 
for the case of `array_agg` I tried overriding type to 
    `x -> createSqlType(SqlTypeName.ARRAY, true)`
   
https://github.com/apache/beam/blob/dcc1812ab1cee26e09c3d6c3c6d3fe2496ac4f65/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L92
   but an assert fails with `java.lang.AssertionError: use createArrayType() 
instead`
   I looked into `createArrayType()` implementation, and it creates an 
`ArraySqlType` with `nullable = false`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 650774)
    Time Spent: 12h 40m  (was: 12.5h)

> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
>                 Key: BEAM-12100
>                 URL: https://issues.apache.org/jira/browse/BEAM-12100
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql-zetasql
>            Reporter: Kyle Weaver
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 12h 40m
>  Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1 
> UNION ALL SELECT CAST(1 as int64))
> should return an error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to