[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=216311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216311
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 16:34
Start Date: 20/Mar/19 16:34
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8076: [BEAM-6619]
[BEAM-6593] Add bigquery integration tests to postcommit
URL: https://github.com/apache/beam/pull/8076#discussion_r267431454
##########
File path: sdks/python/apache_beam/examples/complete/game/game_stats_it_test.py
##########
@@ -52,7 +52,7 @@
class GameStatsIT(unittest.TestCase):
# Input events containing user, team, score, processing time, window start.
- INPUT_EVENT = 'user1,teamA,10,%d,2015-11-02 09:09:28.224'
+ INPUT_EVENT = b'user1,teamA,10,%d,2015-11-02 09:09:28.224'
Review comment:
I am not sure if this should be bytes. Does self.pub_client.publish require
bytes? If so, we should encode before passing data to that method,
To quote https://docs.python.org/3/howto/pyporting.html , `Decode binary
data to text as soon as possible, encode text as binary data as late as
possible`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216311)
Time Spent: 20h 10m (was: 20h)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 20h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
