[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=216309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216309
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 16:34
Start Date: 20/Mar/19 16:34
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8076: [BEAM-6619]
[BEAM-6593] Add bigquery integration tests to postcommit
URL: https://github.com/apache/beam/pull/8076#discussion_r267428713
##########
File path: sdks/python/apache_beam/examples/complete/game/leader_board.py
##########
@@ -120,6 +120,8 @@ def __init__(self):
def process(self, elem):
try:
+ if isinstance(elem, bytes):
Review comment:
Can we always decode here? It is better to have a clear expectation of input
arguments as much as possible on Python 3: either always encoded bytes, or
always strings, but not mixing the two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216309)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
