[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=216363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216363
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 17:54
Start Date: 20/Mar/19 17:54
Worklog Time Spent: 10m
Work Description: Juta commented on pull request #8076: [BEAM-6619]
[BEAM-6593] Add bigquery integration tests to postcommit
URL: https://github.com/apache/beam/pull/8076#discussion_r267471449
##########
File path: sdks/python/apache_beam/examples/complete/game/leader_board.py
##########
@@ -120,6 +120,8 @@ def __init__(self):
def process(self, elem):
try:
+ if isinstance(elem, bytes):
Review comment:
The IT test uses pubsub as input source while the unit test currently passes
strings. That's why we cannot always decode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216363)
Time Spent: 20h 20m (was: 20h 10m)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 20h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)