[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=217283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217283
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/19 15:08
Start Date: 22/Mar/19 15:08
Worklog Time Spent: 10m
Work Description: Juta commented on pull request #8076: [BEAM-6619]
[BEAM-6593] Add bigquery integration tests to postcommit
URL: https://github.com/apache/beam/pull/8076#discussion_r268210466
##########
File path: sdks/python/apache_beam/examples/complete/game/leader_board.py
##########
@@ -120,6 +120,8 @@ def __init__(self):
def process(self, elem):
try:
+ if isinstance(elem, bytes):
Review comment:
The code for leader_board and game_stats is used both with strings
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/complete/game/leader_board_test.py#L45
and with pubsub messages:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/complete/game/leader_board_it_test.py#L146.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217283)
Time Spent: 21h 20m (was: 21h 10m)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 21h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
