[
https://issues.apache.org/jira/browse/BEAM-14546?focusedWorklogId=777628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777628
]
ASF GitHub Bot logged work on BEAM-14546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 15:04
Start Date: 02/Jun/22 15:04
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on PR #17813:
URL: https://github.com/apache/beam/pull/17813#issuecomment-1144972749
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any
comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review
comments).
Issue Time Tracking
-------------------
Worklog Id: (was: 777628)
Time Spent: 50m (was: 40m)
> [Go SDK] passert.Count succeeds for empty PCollections.
> -------------------------------------------------------
>
> Key: BEAM-14546
> URL: https://issues.apache.org/jira/browse/BEAM-14546
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 50m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28
> Since it's using a Combine to do the count, it never executes for empty
> Pcollections, and is unable to fail.
> The fix is: when count > 0, plumb the pcollection through as a side input to
> a DoFn that requires the side input to be non-empty. This would catch the
> empty PCollection case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
