[
https://issues.apache.org/jira/browse/BEAM-14546?focusedWorklogId=777745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777745
]
ASF GitHub Bot logged work on BEAM-14546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 17:33
Start Date: 02/Jun/22 17:33
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on code in PR #17813:
URL: https://github.com/apache/beam/pull/17813#discussion_r888212697
##########
sdks/go/pkg/beam/testing/passert/count.go:
##########
@@ -30,6 +30,10 @@ func Count(s beam.Scope, col beam.PCollection, name string,
count int) {
if typex.IsKV(col.Type()) {
col = beam.DropKey(s, col)
}
+
+ if count > 0 {
+ NonEmpty(s, col)
Review Comment:
Added a small "fail on empty" check for Hash.
Issue Time Tracking
-------------------
Worklog Id: (was: 777745)
Time Spent: 2h 10m (was: 2h)
> [Go SDK] passert.Count succeeds for empty PCollections.
> -------------------------------------------------------
>
> Key: BEAM-14546
> URL: https://issues.apache.org/jira/browse/BEAM-14546
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28
> Since it's using a Combine to do the count, it never executes for empty
> Pcollections, and is unable to fail.
> The fix is: when count > 0, plumb the pcollection through as a side input to
> a DoFn that requires the side input to be non-empty. This would catch the
> empty PCollection case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
