[
https://issues.apache.org/jira/browse/BEAM-14546?focusedWorklogId=777718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777718
]
ASF GitHub Bot logged work on BEAM-14546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 17:04
Start Date: 02/Jun/22 17:04
Worklog Time Spent: 10m
Work Description: jrmccluskey commented on PR #17813:
URL: https://github.com/apache/beam/pull/17813#issuecomment-1145098548
Found the problem, the synthetic StepCfg struct was not exported so the
number of elements to emit in the synthetic tests was getting set to 0,
producing empty PCollections
Issue Time Tracking
-------------------
Worklog Id: (was: 777718)
Time Spent: 1h 50m (was: 1h 40m)
> [Go SDK] passert.Count succeeds for empty PCollections.
> -------------------------------------------------------
>
> Key: BEAM-14546
> URL: https://issues.apache.org/jira/browse/BEAM-14546
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28
> Since it's using a Combine to do the count, it never executes for empty
> Pcollections, and is unable to fail.
> The fix is: when count > 0, plumb the pcollection through as a side input to
> a DoFn that requires the side input to be non-empty. This would catch the
> empty PCollection case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
