[
https://issues.apache.org/jira/browse/BEAM-14546?focusedWorklogId=777647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777647
]
ASF GitHub Bot logged work on BEAM-14546:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 15:31
Start Date: 02/Jun/22 15:31
Worklog Time Spent: 10m
Work Description: damccorm commented on PR #17813:
URL: https://github.com/apache/beam/pull/17813#issuecomment-1145001536
The portable failure looks legit as well:
```
11:01:07 2022/06/02 14:58:41 2022-06-02 14:58:41. (26): Traceback (most
recent call last):
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py",
line 275, in _run_job
11:01:07 self.result = self._invoke_runner()
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py",
line 297, in _invoke_runner
11:01:07 return fn_runner.FnApiRunner(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 208, in run_via_runner_api
11:01:07 return self.run_stages(stage_context, stages)
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 408, in run_stages
11:01:07 bundle_results = self._execute_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 736, in _execute_bundle
11:01:07 self._run_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 965, in _run_bundle
11:01:07 result, splits = bundle_manager.process_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 1314, in process_bundle
11:01:07 raise RuntimeError(result.error)
11:01:07 RuntimeError: process bundle failed for instruction bundle_15 using
plan 2 : while executing Process for Plan[2]:
11:01:07 2: ParDo[passert.nonEmptyFn] Out:[]
11:01:07 1:
DataSource[S[passert.Count(out)/passert.NonEmpty/Impulse@localhost:38365], i0]
Coder:W;c0_windowed<bytes;c0>!GWC Out:2
11:01:07 caused by:
11:01:07 DoFn[UID:2,
PID:passert.Count(out)/passert.NonEmpty/passert.nonEmptyFn, Name:
github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert.nonEmptyFn] failed:
11:01:07 PCollection is empty, want non-empty collection
11:01:07 2022/06/02 14:58:41 2022-06-02 14:58:41. (27): Error running
pipeline.
11:01:07 Traceback (most recent call last):
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py",
line 275, in _run_job
11:01:07 self.result = self._invoke_runner()
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py",
line 297, in _invoke_runner
11:01:07 return fn_runner.FnApiRunner(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 208, in run_via_runner_api
11:01:07 return self.run_stages(stage_context, stages)
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 408, in run_stages
11:01:07 bundle_results = self._execute_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 736, in _execute_bundle
11:01:07 self._run_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 965, in _run_bundle
11:01:07 result, splits = bundle_manager.process_bundle(
11:01:07 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
line 1314, in process_bundle
11:01:07 raise RuntimeError(result.error)
11:01:07 RuntimeError: process bundle failed for instruction bundle_15 using
plan 2 : while executing Process for Plan[2]:
11:01:07 2: ParDo[passert.nonEmptyFn] Out:[]
11:01:07 1:
DataSource[S[passert.Count(out)/passert.NonEmpty/Impulse@localhost:38365], i0]
Coder:W;c0_windowed<bytes;c0>!GWC Out:2
11:01:07 caused by:
11:01:07 DoFn[UID:2,
PID:passert.Count(out)/passert.NonEmpty/passert.nonEmptyFn, Name:
github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert.nonEmptyFn] failed:
11:01:07 PCollection is empty, want non-empty collection
11:01:07 2022/06/02 14:58:41 Job state: FAILED
11:01:07 ptest.go:108: Failed to execute job: job
go-testsimplepipeline-e0c742f9-4ac7-4f8f-9eff-73c54d6d8617 failed
11:01:07 -
Issue Time Tracking
-------------------
Worklog Id: (was: 777647)
Time Spent: 1h 10m (was: 1h)
> [Go SDK] passert.Count succeeds for empty PCollections.
> -------------------------------------------------------
>
> Key: BEAM-14546
> URL: https://issues.apache.org/jira/browse/BEAM-14546
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28
> Since it's using a Combine to do the count, it never executes for empty
> Pcollections, and is unable to fail.
> The fix is: when count > 0, plumb the pcollection through as a side input to
> a DoFn that requires the side input to be non-empty. This would catch the
> empty PCollection case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
