[ 
https://issues.apache.org/jira/browse/BEAM-7121?focusedWorklogId=233124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233124
 ]

ASF GitHub Bot logged work on BEAM-7121:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Apr/19 21:55
            Start Date: 25/Apr/19 21:55
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on issue #8377: [BEAM-7121] 
Add deterministic proto coder
URL: https://github.com/apache/beam/pull/8377#issuecomment-486852058
 
 
   Thanks.
   
   @yifanmai @aaltay @robertwb What is the rationale for keeping both 
ProtoCoder and DeterministicProtoCoder going forward?  Is there so much of a 
performance difference?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 233124)
    Time Spent: 1h  (was: 50m)

> Provide deterministic version of Python's ProtoCoder
> ----------------------------------------------------
>
>                 Key: BEAM-7121
>                 URL: https://issues.apache.org/jira/browse/BEAM-7121
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Yifan Mai
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Passing deterministic=true to proto's 
> [SerializeToString|https://github.com/protocolbuffers/protobuf/blob/60b66a119d17f0a2a595a231bea87cd4f4cf2689/python/google/protobuf/message.py#L189-L204]
>  will result in deterministic encoding of maps in protos. This can be used to 
> provide a deterministic version of ProtoCoder.
> This would allow protos to be used as a key for grouping by key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to