[
https://issues.apache.org/jira/browse/BEAM-7121?focusedWorklogId=234462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234462
]
ASF GitHub Bot logged work on BEAM-7121:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 11:44
Start Date: 29/Apr/19 11:44
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #8377: [BEAM-7121] Add
deterministic proto coder
URL: https://github.com/apache/beam/pull/8377#issuecomment-487548070
I see little, if any, motivation for both. But it'd be good for someone to
verify (looking at code and maybe simple benchmarks) if it really matters
performance wise before making this call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234462)
Time Spent: 1h 20m (was: 1h 10m)
> Provide deterministic version of Python's ProtoCoder
> ----------------------------------------------------
>
> Key: BEAM-7121
> URL: https://issues.apache.org/jira/browse/BEAM-7121
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Yifan Mai
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Passing deterministic=true to proto's
> [SerializeToString|https://github.com/protocolbuffers/protobuf/blob/60b66a119d17f0a2a595a231bea87cd4f4cf2689/python/google/protobuf/message.py#L189-L204]
> will result in deterministic encoding of maps in protos. This can be used to
> provide a deterministic version of ProtoCoder.
> This would allow protos to be used as a key for grouping by key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)