[
https://issues.apache.org/jira/browse/BEAM-7121?focusedWorklogId=233126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233126
]
ASF GitHub Bot logged work on BEAM-7121:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 21:56
Start Date: 25/Apr/19 21:56
Worklog Time Spent: 10m
Work Description: charlesccychen commented on issue #8377: [BEAM-7121]
Add deterministic proto coder
URL: https://github.com/apache/beam/pull/8377#issuecomment-486852299
Also note that precommits fail because of lint:
```
11:31:44 > Task :beam-sdks-python:lintPy27 FAILED
11:31:44 ************* Module apache_beam.coders.coders_test
11:31:44 C: 95, 0: Line too long (102/80) (line-too-long)
11:31:44
11:31:44 --------------------------------------------------------------------
11:31:44 Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)
11:31:44
11:31:44 Command exited with non-zero status 16
11:31:44 601.37user 16.20system 2:47.52elapsed 368%CPU (0avgtext+0avgdata
422480maxresident)k
11:31:44 0inputs+224outputs (0major+828313minor)pagefaults 0swaps
11:31:44 ERROR: InvocationError for command '/usr/bin/time
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/scripts/run_pylint.sh'
(exited with code 16)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233126)
Time Spent: 1h 10m (was: 1h)
> Provide deterministic version of Python's ProtoCoder
> ----------------------------------------------------
>
> Key: BEAM-7121
> URL: https://issues.apache.org/jira/browse/BEAM-7121
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Yifan Mai
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Passing deterministic=true to proto's
> [SerializeToString|https://github.com/protocolbuffers/protobuf/blob/60b66a119d17f0a2a595a231bea87cd4f4cf2689/python/google/protobuf/message.py#L189-L204]
> will result in deterministic encoding of maps in protos. This can be used to
> provide a deterministic version of ProtoCoder.
> This would allow protos to be used as a key for grouping by key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
