[ 
https://issues.apache.org/jira/browse/BEAM-7121?focusedWorklogId=240437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240437
 ]

ASF GitHub Bot logged work on BEAM-7121:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/May/19 21:48
            Start Date: 10/May/19 21:48
    Worklog Time Spent: 10m 
      Work Description: yifanmai commented on issue #8377: [BEAM-7121] Add 
deterministic proto coder
URL: https://github.com/apache/beam/pull/8377#issuecomment-491439857
 
 
   `apache_beam.transforms.util_test.BatchElementsTest.test_numpy_regression` 
fails for _only_ `:beam-sdks-python-test-suites-tox-py36:testPy36Cython` with 
`AssertionError: 5.010096933686919 != 5 within 0.01 delta`.
   
   This seems non-deterministic and unrelated. Might have to do with this PR 
changing the PRNG state. Can I bump the threshold up from 0.01 to 0.02?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 240437)
    Time Spent: 2.5h  (was: 2h 20m)

> Provide deterministic version of Python's ProtoCoder
> ----------------------------------------------------
>
>                 Key: BEAM-7121
>                 URL: https://issues.apache.org/jira/browse/BEAM-7121
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Yifan Mai
>            Priority: Minor
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Passing deterministic=true to proto's 
> [SerializeToString|https://github.com/protocolbuffers/protobuf/blob/60b66a119d17f0a2a595a231bea87cd4f4cf2689/python/google/protobuf/message.py#L189-L204]
>  will result in deterministic encoding of maps in protos. This can be used to 
> provide a deterministic version of ProtoCoder.
> This would allow protos to be used as a key for grouping by key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to