[
https://issues.apache.org/jira/browse/BEAM-562?focusedWorklogId=233836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233836
]
ASF GitHub Bot logged work on BEAM-562:
---------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/19 01:45
Start Date: 27/Apr/19 01:45
Worklog Time Spent: 10m
Work Description: yifanmai commented on issue #7994: [BEAM-562] Add
DoFn.setup and DoFn.teardown to Python SDK
URL: https://github.com/apache/beam/pull/7994#issuecomment-487244815
Added a test to ensure that shutdown is called on DirectRunner. PTAL
I discovered that metrics counter increments during setup and teardown will
not be registered in the pipeline result metrics. I'm not sure if this should
be considered a bug, since setup and teardown may could happen outside the
pipeline run (it happens within the pipeline run for DirectRunner, but not
necessarily for other runners) I looked at the metrics API, but could not
figure out how to set up the metrics environment correctly for those stages.
@aaltay do you have any suggestions on how to handle this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233836)
Time Spent: 7h 10m (was: 7h)
> DoFn Reuse: Add new methods to DoFn
> -----------------------------------
>
> Key: BEAM-562
> URL: https://issues.apache.org/jira/browse/BEAM-562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Priority: Major
> Labels: sdk-consistency, triaged
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Java SDK added setup and teardown methods to the DoFns. This makes DoFns
> reusable and provide performance improvements. Python SDK should add support
> for these new DoFn methods:
> Proposal doc:
> https://docs.google.com/document/d/1LLQqggSePURt3XavKBGV7SZJYQ4NW8yCu63lBchzMRk/edit?ts=5771458f#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
