[
https://issues.apache.org/jira/browse/BEAM-562?focusedWorklogId=237940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237940
]
ASF GitHub Bot logged work on BEAM-562:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/19 17:32
Start Date: 06/May/19 17:32
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #7994: [BEAM-562] Add
DoFn.setup and DoFn.teardown to Python SDK
URL: https://github.com/apache/beam/pull/7994#issuecomment-489705616
The change LGTM. But there are test errors. Please take a look at those.
(If you need help with py3 compatibility, cc: @tvalentyn could help.)
One I found in the logs is the following, there might be other errors as
well:
6:57:54 FAILED (SKIP=448, errors=24, failures=5)
16:57:54 ERROR: InvocationError for command
'/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/test-suites/tox/py35/build/srcs/sdks/python/target/.tox-py35-cython/py35-cython/bin/python
setup.py nosetests' (exited with code 1)
16:57:54 ___________________________________ summary
____________________________________
16:57:54 ERROR: py35-cython: commands failed
16:58:01 File "/usr/lib/python2.7/threading.py", line 801, in
__bootstrap_inner
16:58:01 self.run()
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/local_job_service.py",
line 245, in run
16:58:01 self._pipeline_proto)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py",
line 281, in run_via_runner_api
16:58:01 return self.run_stages(*self.create_stages(pipeline_proto))
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py",
line 357, in run_stages
16:58:01 stage_context.safe_coders)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py",
line 521, in run_stage
16:58:01 data_input, data_output)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py",
line 1227, in process_bundle
16:58:01 result_future =
self._controller.control_handler.push(process_bundle)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/portability/fn_api_runner.py",
line 842, in push
16:58:01 response = self.worker.do_instruction(request)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py",
line 342, in do_instruction
16:58:01 request.instruction_id)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py",
line 382, in process_bundle
16:58:01 self.bundle_processor_cache.discard(instruction_id)
16:58:01 File
"/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/build/srcs/sdks/python/apache_beam/runners/worker/sdk_worker.py",
line 314, in discard
16:58:01 self.active_bundle_processors[instruction_id].shutdown()
16:58:01 AttributeError: 'tuple' object has no attribute 'shutdown'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 237940)
Time Spent: 8h 40m (was: 8.5h)
> DoFn Reuse: Add new methods to DoFn
> -----------------------------------
>
> Key: BEAM-562
> URL: https://issues.apache.org/jira/browse/BEAM-562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Labels: sdk-consistency
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Java SDK added setup and teardown methods to the DoFns. This makes DoFns
> reusable and provide performance improvements. Python SDK should add support
> for these new DoFn methods:
> Proposal doc:
> https://docs.google.com/document/d/1LLQqggSePURt3XavKBGV7SZJYQ4NW8yCu63lBchzMRk/edit?ts=5771458f#
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
