[ https://issues.apache.org/jira/browse/BEAM-562?focusedWorklogId=240431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240431 ]
ASF GitHub Bot logged work on BEAM-562: --------------------------------------- Author: ASF GitHub Bot Created on: 10/May/19 21:38 Start Date: 10/May/19 21:38 Worklog Time Spent: 10m Work Description: yifanmai commented on issue #7994: [BEAM-562] Add DoFn.setup and DoFn.teardown to Python SDK URL: https://github.com/apache/beam/pull/7994#issuecomment-491437737 The shutdown assert is breaking in Dataflow also (because it only works for in-process). Can I delete that assert, or disable it for Dataflow? ``` 14:22:11 Traceback (most recent call last): 14:22:11 File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python3_Verify_PR/src/sdks/python/apache_beam/transforms/dofn_lifecycle_test.py", line 90, in test_dofn_lifecycle 14:22:11 self.assertTrue(_global_teardown_called) 14:22:11 AssertionError: False is not true ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 240431) Time Spent: 9.5h (was: 9h 20m) > DoFn Reuse: Add new methods to DoFn > ----------------------------------- > > Key: BEAM-562 > URL: https://issues.apache.org/jira/browse/BEAM-562 > Project: Beam > Issue Type: New Feature > Components: sdk-py-core > Reporter: Ahmet Altay > Assignee: Yifan Mai > Priority: Major > Labels: sdk-consistency > Time Spent: 9.5h > Remaining Estimate: 0h > > Java SDK added setup and teardown methods to the DoFns. This makes DoFns > reusable and provide performance improvements. Python SDK should add support > for these new DoFn methods: > Proposal doc: > https://docs.google.com/document/d/1LLQqggSePURt3XavKBGV7SZJYQ4NW8yCu63lBchzMRk/edit?ts=5771458f# -- This message was sent by Atlassian JIRA (v7.6.3#76005)