[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=304309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304309
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 15:20
Start Date: 30/Aug/19 15:20
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9447: [WIP]
[BEAM-7013] Handle null input in HllCount.MergePartial and HllCount.Extract
URL: https://github.com/apache/beam/pull/9447#discussion_r319555345
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCount.java
##########
@@ -346,7 +346,9 @@ private Extract() {}
@ProcessElement
public void processElement(
@Element byte[] sketch, OutputReceiver<Long> receiver) {
-
receiver.output(HyperLogLogPlusPlus.forProto(sketch).result());
+ Long result =
+ (sketch == null) ? 0L :
HyperLogLogPlusPlus.forProto(sketch).result();
Review comment:
Would it make sense to document the nullability of the sketch param
somewhere -- method doc or @nullable annotation on param, ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304309)
Time Spent: 29h 10m (was: 29h)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 29h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
