[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=304310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304310
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 15:20
Start Date: 30/Aug/19 15:20
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9447: [WIP]
[BEAM-7013] Handle null input in HllCount.MergePartial and HllCount.Extract
URL: https://github.com/apache/beam/pull/9447#discussion_r319559575
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCountMergePartialFn.java
##########
@@ -94,9 +95,9 @@ private HllCountMergePartialFn() {}
@Override
public byte[] extractOutput(@Nullable HyperLogLogPlusPlus<HllT> accumulator)
{
if (accumulator == null) {
- throw new IllegalStateException(
- "HllCountMergePartialFn.extractOutput() should not be called on a
null accumulator.");
+ return null;
Review comment:
same here (annotation + is this handled well everywhere downstream?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 304310)
Time Spent: 29h 20m (was: 29h 10m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 29h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
