[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=325398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325398
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 00:12
Start Date: 09/Oct/19 00:12
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #9188:
[BEAM-7886] Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r332785140
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/CoderTranslators.java
##########
@@ -118,6 +124,33 @@ public T fromComponents(List<Coder<?>> components) {
};
}
+ static CoderTranslator<RowCoder> row() {
+ return new CoderTranslator<RowCoder>() {
+ @Override
+ public List<? extends Coder<?>> getComponents(RowCoder from) {
+ return ImmutableList.of();
Review comment:
Yes right now there's just a fixed mapping from fieldtype to coder. There's
not a bug filed for using components, I was thinking that we would just
continue inlining everything. Do you think we should plan on using components
instead? What does that get us?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 325398)
Time Spent: 12h 10m (was: 12h)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
