[
https://issues.apache.org/jira/browse/BEAM-7886?focusedWorklogId=325402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325402
]
ASF GitHub Bot logged work on BEAM-7886:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 00:34
Start Date: 09/Oct/19 00:34
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #9188:
[BEAM-7886] Make row coder a standard coder and implement in Python
URL: https://github.com/apache/beam/pull/9188#discussion_r332788742
##########
File path: sdks/python/apache_beam/coders/standard_coders_test.py
##########
@@ -133,11 +171,17 @@ def parse_coder(self, spec):
for c in spec.get('components', ())]
context.coders.put_proto(coder_id, beam_runner_api_pb2.Coder(
spec=beam_runner_api_pb2.FunctionSpec(
- urn=spec['urn'], payload=spec.get('payload')),
+ urn=spec['urn'], payload=spec.get('payload', '').encode()),
Review comment:
Yeah this was just a fix I slipped in to get the test working in Python 3
and forgot about..
It should probably specify an encoding. Do you think it should be `latin1`
like we do with the [expected encoded
value](https://github.com/apache/beam/blob/master/sdks/python/apache_beam/coders/standard_coders_test.py#L115)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 325402)
Time Spent: 12h 20m (was: 12h 10m)
> Make row coder a standard coder and implement in python
> -------------------------------------------------------
>
> Key: BEAM-7886
> URL: https://issues.apache.org/jira/browse/BEAM-7886
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-java-core, sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
