[
https://issues.apache.org/jira/browse/BEAM-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998381#comment-16998381
]
Maximilian Michels commented on BEAM-5495:
------------------------------------------
{quote}
Side note: I am more than happy if this becomes a beam extension, this is
always deactivated in real life anyway since the scanning is 99% of the time
wrong.
{quote}
Every company I've worked with used this feature, nobody sets the staged files
manually. It works fairly well in isolated environments, it might not if you
use some kind of application server, but then you can always set the staged
files manually. IMHO making this is a plugin of some sort would be equivalent
of deleting the code.
If you want to make this more extensible, e.g. via your idea to add filters, I
think that would be a good addition.
> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
> Key: BEAM-5495
> URL: https://issues.apache.org/jira/browse/BEAM-5495
> Project: Beam
> Issue Type: Bug
> Components: runner-flink, runner-spark, sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Lukasz Gajowy
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the
> staged file
> Looks like this detect resource algorithm can't work and should be replaced
> by a SPI rather than a built-in and not extensible algorithm. Another valid
> alternative is to just drop that "guess" logic and force the user to set
> staged files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
