[ 
https://issues.apache.org/jira/browse/BEAM-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999026#comment-16999026
 ] 

Maximilian Michels commented on BEAM-5495:
------------------------------------------

To address your other concern:

{quote}
Any reason to use a one man github project (io.github.classgraph:classgraph) 
instead of apache xbean proposal?
{quote}

ClassGraph: 4097 commits, 33 contributors, 304 releases.
Xbean: 992 commits, 12 contributors, 48 releases.

ClassGraph appears to be more active. I value your concern but I think 
ClassGraph was a valid choice, also given the that it scoped for exactly this 
purpose, whereas xbean seems to be written for a different purpose and its 
documentation does not make it obvious how to use it for detecting classloader 
dependencies.

> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
>                 Key: BEAM-5495
>                 URL: https://issues.apache.org/jira/browse/BEAM-5495
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink, runner-spark, sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Assignee: Lukasz Gajowy
>            Priority: Major
>             Fix For: 2.19.0
>
>          Time Spent: 15h 40m
>  Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java 
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the 
> staged file
> Looks like this detect resource algorithm can't work and should be replaced 
> by a SPI rather than a built-in and not extensible algorithm. Another valid 
> alternative is to just drop that "guess" logic and force the user to set 
> staged files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to