[ 
https://issues.apache.org/jira/browse/BEAM-5495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999186#comment-16999186
 ] 

Romain Manni-Bucau commented on BEAM-5495:
------------------------------------------

[~mxm]think you got abused by github ;) (see 
[https://github.com/classgraph/classgraph/graphs/contributors] vs 
[https://github.com/apache/geronimo-xbean/graphs/contributors]). Anyway, not a 
blocker. Guess it should be made provided/optional in the deployed pom since it 
is a flippable feature (at least at sdk level) and ArchUnit or equivalent can 
be used to ensure it is limited to the scanner and classgraph is not used 
outside of that class to ensure it can still be dropped.

> PipelineResources algorithm is not working in most environments
> ---------------------------------------------------------------
>
>                 Key: BEAM-5495
>                 URL: https://issues.apache.org/jira/browse/BEAM-5495
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink, runner-spark, sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Assignee: Lukasz Gajowy
>            Priority: Major
>             Fix For: 2.19.0
>
>          Time Spent: 15h 50m
>  Remaining Estimate: 0h
>
> Issue are:
> 1. it assumes the classloader is an URLClassLoader (not always true and java 
> >= 9 breaks that as well for the app loader)
> 2. it uses loader.getURLs() which leads to including the JRE itself in the 
> staged file
> Looks like this detect resource algorithm can't work and should be replaced 
> by a SPI rather than a built-in and not extensible algorithm. Another valid 
> alternative is to just drop that "guess" logic and force the user to set 
> staged files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to