[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=419040&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419040
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 00:38
Start Date: 09/Apr/20 00:38
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #11314:
[BEAM-9562] Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r405892635
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/graph/RegisterNodeFunction.java
##########
@@ -134,14 +136,18 @@ public static RegisterNodeFunction forPipeline(
* harnesses, then this method should be removed.
*/
public static RegisterNodeFunction withoutPipeline(
- IdGenerator idGenerator, Endpoints.ApiServiceDescriptor
stateApiServiceDescriptor) {
- return new RegisterNodeFunction(null, idGenerator,
stateApiServiceDescriptor);
+ IdGenerator idGenerator,
+ Endpoints.ApiServiceDescriptor stateApiServiceDescriptor,
+ Endpoints.ApiServiceDescriptor timerApiServiceDescriptor) {
+ return new RegisterNodeFunction(
+ null, idGenerator, stateApiServiceDescriptor,
timerApiServiceDescriptor);
}
private RegisterNodeFunction(
@Nullable RunnerApi.Pipeline pipeline,
IdGenerator idGenerator,
- Endpoints.ApiServiceDescriptor stateApiServiceDescriptor) {
+ Endpoints.ApiServiceDescriptor stateApiServiceDescriptor,
+ Endpoints.ApiServiceDescriptor timerApiServiceDescriptor) {
Review comment:
timerApiServiceDescriptor isn't used? Should it be stored and written to the
ProcessBundleDescrioptor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419040)
Time Spent: 15h 50m (was: 15h 40m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
