reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140912015
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -612,6 +629,51 @@ public void asyncReadUnconfirmedEntries(long firstEntry,
long lastEntry, ReadCal
asyncReadEntriesInternal(firstEntry, lastEntry, cb, ctx);
}
+ /**
+ * Read a sequence of entries asynchronously.
+ *
+ * @param firstEntry
+ * id of first entry of sequence
+ * @param lastEntry
+ * id of last entry of sequence
+ */
+ @Override
+ public
CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>>
read(long firstEntry, long lastEntry) {
Review comment:
this is public API, it is confusing to have so many read calls
readEntries
asyncReadEntries
read (and now)
1) naming of this method doesnt sound appropriate. It is not saying exactly
how is it different from other read calls.
2) why are we making these changes in this pull request / commit, probably
it would be better to limit this commit to builder interface of
create/open/delete operations and create separate PR/commit for these
ledgerhandle changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
