reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140924048
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -612,6 +629,51 @@ public void asyncReadUnconfirmedEntries(long firstEntry,
long lastEntry, ReadCal
asyncReadEntriesInternal(firstEntry, lastEntry, cb, ctx);
}
+ /**
+ * Read a sequence of entries asynchronously.
+ *
+ * @param firstEntry
+ * id of first entry of sequence
+ * @param lastEntry
+ * id of last entry of sequence
+ */
+ @Override
+ public
CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>>
read(long firstEntry, long lastEntry) {
Review comment:
ok..i briefly went through all the classes.. you are planning to make
org.apache.bookkeeper.client.api as customer facing/public package/classes. But
for the sake of backward compatibility you would leave existing
org.apache.bookkeeper.client classes as public, right? But there is confusion,
regarding the changes you are making
- do you have any plans of deprecating or making non-public, existing
org.apache.bookkeeper.client classes, so that new users would be less confused
and use new classes/API
- even with your new set of classes/package
org.apache.bookkeeper.client.BookKeeper is the entry point for Bookkeeper API,
it would be confusing for users to create instance of client.BookKeeper class
and then start using bookkeeper.client.api for their operations.
- is it not necessary for new bookkeeper.client.api apis to be on par with
org.apache.bookkeeper.client APIs? I dont see equivalent methods for
ledgerHandle.getCustomMetadata, getNumFragments, ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
