reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140925232
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -628,6 +690,22 @@ public long addEntry(byte[] data) throws
InterruptedException, BKException {
return addEntry(data, 0, data.length);
}
+ @Override
+ public CompletableFuture<Long> append(ByteBuffer data) {
Review comment:
you made this class (LedgerHandle.java) implement client.api.WriteHandle,
this is not making sense to me
1) if your plan is to make org.apache.bookkeeper.client.api public package
and org.apache.bookkeeper.client internal package, why do you want internal
package class implements external interface
2) ReadOnlyLedgerHandle extends LedgerHandle class, so these methods are
also methods of ReadOnlyLedgerHandle, but that doesn't make sense for
ReadOnlyLedgerHandle to have 'append' methods
3) what is the relation between client package handles (ReadOnlyLedgerHandle
and LedgerHandle) and client.api package handles (Handle, ReadHandle,
WriteHandle)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
