reddycharan commented on a change in pull request #510: Issue-605 BP-15 New
CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r140926007
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -612,6 +629,51 @@ public void asyncReadUnconfirmedEntries(long firstEntry,
long lastEntry, ReadCal
asyncReadEntriesInternal(firstEntry, lastEntry, cb, ctx);
}
+ /**
+ * Read a sequence of entries asynchronously.
+ *
+ * @param firstEntry
+ * id of first entry of sequence
+ * @param lastEntry
+ * id of last entry of sequence
+ */
+ @Override
+ public
CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>>
read(long firstEntry, long lastEntry) {
Review comment:
@eolivelli I'll wait for your comments before doing further review. In
summary I want to understand relation between org.apache.bookkeeper.client
package and org.apache.bookkeeper.client.api package and their corresponding
classes.
I was expecting just builder interfaces for create, open and delete op as
part of this change.
@jvrao FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
