sijie commented on a change in pull request #727: Issue 693: add interface and 
implementation of LedgerEntries
URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152480808
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -675,8 +675,8 @@ public void asyncReadUnconfirmedEntries(long firstEntry, 
long lastEntry, ReadCal
      * @see #readUnconfirmedEntries(long, long)
      */
     @Override
-    public 
CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>> 
readUnconfirmed(long firstEntry, long lastEntry) {
-        // Little sanity check
+    public CompletableFuture<org.apache.bookkeeper.client.api.LedgerEntries> 
readUnconfirmed(long firstEntry,
+                                                                               
              long lastEntry) {        // Little sanity check
 
 Review comment:
   need put the comment in a new line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to