sijie commented on a change in pull request #727: Issue 693: add interface and
implementation of LedgerEntries
URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152480729
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -634,7 +634,7 @@ public void asyncReadUnconfirmedEntries(long firstEntry,
long lastEntry, ReadCal
* id of last entry of sequence
*/
@Override
- public
CompletableFuture<Iterable<org.apache.bookkeeper.client.api.LedgerEntry>>
read(long firstEntry, long lastEntry) {
+ public CompletableFuture<org.apache.bookkeeper.client.api.LedgerEntries>
read(long firstEntry, long lastEntry) {
Review comment:
nit: I don't think you need fully qualified path name. it can just be
`CompletableFuture<LedgerEntries>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
