sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152509887
########## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/impl/LedgerEntriesImplTest.java ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.bookkeeper.client.impl; + +import static com.google.common.base.Charsets.UTF_8; +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; + +import com.google.common.collect.Lists; +import io.netty.buffer.ByteBuf; +import io.netty.buffer.Unpooled; +import java.util.Iterator; +import java.util.List; +import org.apache.bookkeeper.client.api.LedgerEntry; +import org.junit.After; +import org.junit.Test; + +/** + * Unit test for {@link LedgerEntriesImpl}. + */ +public class LedgerEntriesImplTest { + private final int entryNumber = 7; + private LedgerEntriesImpl ledgerEntriesImpl; + private final List<LedgerEntry> entryList = Lists.newArrayList(); + + // content for each entry + private final long ledgerId = 1234L; + private final long entryId = 5678L; + private final long length = 9876L; + private final byte[] dataBytes = "test-ledger-entry-impl".getBytes(UTF_8); + + public LedgerEntriesImplTest () { + for(int i = 0; i < entryNumber; i++) { + entryList.add(LedgerEntryImpl.create(ledgerId + i, + entryId + i, + length + i, + Unpooled.wrappedBuffer(dataBytes))); + } + + ledgerEntriesImpl = LedgerEntriesImpl.create(entryList); + } + + @After + public void tearDown() { + ledgerEntriesImpl.close(); + + try { + ledgerEntriesImpl.getEntry(entryId); + fail("should fail getEntry after close"); + } catch (NullPointerException e) { + + } + + try { + ledgerEntriesImpl.iterator(); + fail("should fail iterator after close"); + } catch (NullPointerException e) { + + } + + try { + ledgerEntriesImpl.retainIterator(); + fail("should fail retainIterator after close"); + } catch (NullPointerException e) { + + } + } + + @Test + public void testGetEntry() { + for(int i = 0; i < entryNumber; i ++) { + LedgerEntry entry = ledgerEntriesImpl.getEntry(entryId + i); + assertEquals(entryList.get(i).getLedgerId(), entry.getLedgerId()); + assertEquals(entryList.get(i).getEntryId(), entry.getEntryId()); + assertEquals(entryList.get(i).getLength(), entry.getLength()); + + ByteBuf buf = entry.getEntryBuffer(); + byte[] content = new byte[buf.readableBytes()]; + buf.readBytes(content); + assertArrayEquals(dataBytes, content); + + assertEquals(1, entry.getEntryBuffer().refCnt()); + } + + try { + LedgerEntry entry = ledgerEntriesImpl.getEntry(entryId - 1); + fail("Should get IndexOutOfBoundsException"); + } catch (IndexOutOfBoundsException e) { + + } + + try { + LedgerEntry entry = ledgerEntriesImpl.getEntry(entryId + entryNumber); + fail("Should get IndexOutOfBoundsException"); + } catch (IndexOutOfBoundsException e) { + + } + } + + @Test + public void testIterator() { + Iterator<LedgerEntry> entryIterator = ledgerEntriesImpl.iterator(); + entryIterator.forEachRemaining(ledgerEntry -> assertEquals(1, ledgerEntry.getEntryBuffer().refCnt())); + } + + @Test + public void testRetainIterator() { + Iterator<LedgerEntry> entryIterator = ledgerEntriesImpl.retainIterator(); + entryIterator.forEachRemaining(ledgerEntry -> assertEquals(2, ledgerEntry.getEntryBuffer().refCnt())); + entryIterator.forEachRemaining(ledgerEntry -> ledgerEntry.getEntryBuffer().release()); Review comment: I think this will not be tested. `forEachRemaining` will consume the iterator. you might need change this to ``` entryIterator.forEachRemaining(ledgerEntry -> { assertEquals(2, ledgerEntry.getEntryBuffer().refCnt()); ledgerEntry.getEntryBuffer().release(); assertEquals(1, ledgerEntry.getEntryBuffer().refCnt()); }) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
