sijie commented on a change in pull request #727: Issue 693: add interface and
implementation of LedgerEntries
URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152481777
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperApiTest.java
##########
@@ -275,11 +276,13 @@ public void testCannotDeleteLedgerTwice() throws
Exception {
result(newDeleteLedgerOp().withLedgerId(lId).execute());
}
- private static void checkEntries(Iterable<LedgerEntry> entries, byte[]
data)
+ private static void checkEntries(LedgerEntries entries, byte[] data)
throws InterruptedException, BKException {
- for (LedgerEntry le : entries) {
- assertArrayEquals(data, le.getEntry());
+ Iterator<LedgerEntry> iterator = entries.retainIterator();
Review comment:
I don't think you need retainIterator here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
