sijie commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC
Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r157030635
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -1444,17 +1460,23 @@ void sendAddSuccessCallbacks() {
return;
}
// Check if it is the next entry in the sequence.
- if (pendingAddOp.entryId != 0 && pendingAddOp.entryId !=
lastAddConfirmed + 1) {
+ if (pendingAddOp.entryId != 0 && pendingAddOp.entryId !=
pendingAddsSequenceHead) {
Review comment:
I would defer introducing `pendingAddsSequenceHead` until `LastAddSynced` is
introduced. At this moment, there is no `LastAddSynced`, so there is no reason
to make change at this moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
