sijie commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r157027097
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LastAddSyncedManager.java ########## @@ -0,0 +1,76 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ +package org.apache.bookkeeper.client; + +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +/** + * Handles LastAddSynced on the client side. + */ +class LastAddSyncedManager { + + private final Map<Integer, Long> lastAddSyncedMap = new HashMap<>(); + private final int writeQuorumSize; + private final int ackQuorumSize; + + public LastAddSyncedManager(int writeQuorumSize, int ackQuorumSize) { + this.writeQuorumSize = writeQuorumSize; + this.ackQuorumSize = ackQuorumSize; + } + + /** + * Save the lastAddSynced value for a given bookie. + * + */ + public void updateBookie(int bookieIndexHeardFrom, long lastAddSynced) { + lastAddSyncedMap.put(bookieIndexHeardFrom, lastAddSynced); + } + + /** + * Estimates the LastAddConfirmed entry. + * + * @return the estimated value, considering the lastAddSynced piggybacked value from each bookie + */ + public long calculateCurrentLastAddSynced() { + /* Review comment: change `/* */` to `//` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
