sijie commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC
Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r157065397
##########
File path:
tests/backward/src/test/java/org/apache/bookkeeper/tests/backward/TestBackwardCompat.java
##########
@@ -314,22 +318,34 @@ void stop() throws Exception {
}
static class LedgerCurrent {
Review comment:
yes, I read the conversation. for this change to be checked in, please test
backward between 4.7 and 4.6/4.5. if there is a need for refactor backward
compatibility tests, lets refactor them now rather than later. that says I can
image more and more changes checked in, we should have something to guarantee
we don't break backward compatibility. that says I would mark backward test
between 4.7 and 4.6/4.5 as a blocker for this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
