sijie commented on a change in pull request #853: BP-14 WriteFlag DEFERRED_SYNC
Client Side Implementation
URL: https://github.com/apache/bookkeeper/pull/853#discussion_r157070637
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##########
@@ -1444,17 +1460,23 @@ void sendAddSuccessCallbacks() {
return;
}
// Check if it is the next entry in the sequence.
- if (pendingAddOp.entryId != 0 && pendingAddOp.entryId !=
lastAddConfirmed + 1) {
+ if (pendingAddOp.entryId != 0 && pendingAddOp.entryId !=
pendingAddsSequenceHead) {
Review comment:
sure. but my concern is no one is actually using this. I was thinking this
pull request only for pushing the flag to the wire. to implementing the actual
logic, you should do the server side first and client side later. Otherwise,
you are pushing a lot of `unused` logic into the client, and we don't know when
they are going to be enabled (given current pull requests are merged very
quickly)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
