eolivelli commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r160080838
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
##########
@@ -118,9 +136,14 @@ public void setup() throws Exception {
ledgerIdGenerator = mock(LedgerIdGenerator.class);
bk = mock(BookKeeper.class);
+ Whitebox.setInternalState(bk, "bookieWatcher", bookieWatcher);
+ Whitebox.setInternalState(bk, "disableEnsembleChangeFeature",
mock(Feature.class));
Review comment:
Same for this, it is better to only use onr approach, that is to overrode
getters and treat the mock as an empty object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
