eolivelli commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r160374667
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
##########
@@ -118,9 +136,14 @@ public void setup() throws Exception {
ledgerIdGenerator = mock(LedgerIdGenerator.class);
bk = mock(BookKeeper.class);
+ Whitebox.setInternalState(bk, "bookieWatcher", bookieWatcher);
+ Whitebox.setInternalState(bk, "disableEnsembleChangeFeature",
mock(Feature.class));
Review comment:
if you find somewhere direct references to bk.disableEnsembleChangeFeature
you should replace them with BookKeeper.getDisableEnsembleChangeFeature
using direct fields references prevents using this mocking approach.
I think we should have only one way of mocking BookKeeper class, in order to
prevent confusion
//cc @sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
