eolivelli commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r163464643
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
##########
@@ -219,7 +272,10 @@ private void submit(Runnable operation) {
}
protected void registerMockEntryForRead(long ledgerId, long entryId,
BookieSocketAddress bookieSocketAddress,
- byte[] entryData, long lastAddConfirmed) {
+ byte[] entryData, long lastAddConfirmed) throws BKException{
+ if (failedBookies.contains(bookieSocketAddress)) {
+ throw BKException.create(NoBookieAvailableException);
Review comment:
This is an error, this is a mock setup method, it is not business logic, you
are not reading/writing at this point. The error manifests on line 396 and it
is the correct behaviour.
I this you should simply drop this 'if' block and than remove the 'throws'
clause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
