eolivelli commented on a change in pull request #925: Issue611: restrict max
ensemble change numbers
URL: https://github.com/apache/bookkeeper/pull/925#discussion_r163401361
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperBuildersTest.java
##########
@@ -340,8 +337,12 @@ public void testOpenLedgerNoRecovery() throws Exception {
ledgerMetadata.getEnsembles().values().forEach(bookieAddressList -> {
bookieAddressList.forEach(bookieAddress -> {
- registerMockEntryForRead(ledgerId,
BookieProtocol.LAST_ADD_CONFIRMED, bookieAddress, entryData, -1);
- registerMockEntryForRead(ledgerId, 0, bookieAddress,
entryData, -1);
+ try {
+ registerMockEntryForRead(ledgerId,
BookieProtocol.LAST_ADD_CONFIRMED, bookieAddress, entryData, -1);
+ registerMockEntryForRead(ledgerId, 0, bookieAddress,
entryData, -1);
Review comment:
Last thing: why registerMockEntryForRead can throw a BKException? Can't we
throw a cchecked exception? Or as last resort you can ise @SneakyThrows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
