sijie commented on a change in pull request #888: Rework of binary distribution 
licenses
URL: https://github.com/apache/bookkeeper/pull/888#discussion_r160503378
 
 

 ##########
 File path: bookkeeper-dist/src/main/resources/NOTICE-all.bin.txt
 ##########
 @@ -1,55 +1,162 @@
 Apache BookKeeper
-Copyright 2011-2017 The Apache Software Foundation
+Copyright 2011-2018 The Apache Software Foundation
 
-Licensed under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This product contains a modified version of 'Circe', a high-performance
+hash algorithm framework & library from Trevor Robinson:
+
+  * LICENSE: Apache License 2.0
 
 Review comment:
   I don't think we need any copy rights in NOTICE per Justin MClean. All these 
below are already in LICENSE. NOTICE is informative and should be as brief as 
possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to