sijie commented on a change in pull request #888: Rework of binary distribution
licenses
URL: https://github.com/apache/bookkeeper/pull/888#discussion_r160501300
##########
File path: bookkeeper-dist/src/assemble/bin-server.xml
##########
@@ -45,6 +45,24 @@
<include>${basedir}/*.txt</include>
</includes>
</fileSet>
+ <fileSet>
+ <directory>../src/main/resources/deps</directory>
+ <outputDirectory>/deps</outputDirectory>
+ <includes>
+ <include>javax.servlet-api-3.1.0/CDDL+GPL-1.1</include>
+ <include>netty-4.1.12.Final/LICENSE.base64.txt</include>
Review comment:
nit: can this simplified with netty-4.1.12.Final/*?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
